gun bug

[Xavious]

whats the big deal anwyas...i wud have thoght youd be happy to get more ammo

[}TCP{Wolf]

UTF-10 from alpha 4 build and upwards will have this bug fixed - but it's only possible to fix it for UTeamWeapons, not any custom guns mod-crazy admins may include in their servers. Nice catch though, Cheiz will be mentioned for finding it...

[}TCP{Cheiz]

Cool! By the way, i made a little mistake:

That can be very mean when you throw it to someone which doesnt have asmd yet; he will get an asmd with 0 bullets and can not pickup a new one but only dead-body-asmds and ammo.

Dead-body-asmds also arent useful becaue you get 0 ammo from them also.
After the fix, is it still possible to throw away (and pick up) 0 ammo guns?

[Kobra]

well..
i dont really understand what is the meaning of "dead-body-guns"
with 0 ammo...

always when i got my own gun and pick up a "dead-body-gun"
i get more ammo then i got before...

i never saw a bug like that before

[Taz]

you haventh played much :O

[}TCP{Wolf]

The original unfixed code works like this:

If you pick up a dropped gun, and you do not yet have this gun already, you get the gun you pick up and any ammo it has (which can be 0 if the player dropping dies right after firing his last shot or tosses the gun that moment).

If you pick up a dropped gun but you already HAVE the gun in your inventory, you get the default pickup amount of ammo added for that weapon class (which would be 20 ammo for asmds). That's what the code says in Weapon.uc::handlepickupquery(inventory Item). I even tested this on a FULL FLAK and I only got 10 ammo when picking it up, not 50 as it should have been.

The fix will always give you the correct amount of ammo on dropped guns now, but only if it is a UTeamWeapon (any standard Unreal Weapon). It is still possible to accidently or intentionally dropping guns with 0 ammo. This is after all not a bug, but a "feature". Remember my primary goal with UTF is patching and adding (mostly administrative) features, not changing original game-play behaviour. I might think of something optional some day...

[}TCP{Cheiz]

If you pick up a dropped gun but you already HAVE the gun in your inventory, you get the default pickup amount of ammo added for that weapon class (which would be 20 ammo for asmds). That's what the code says in Weapon.uc::handlepickupquery(inventory Item). I even tested this on a FULL FLAK and I only got 10 ammo when picking it up, not 50 as it should have been.

This is not 100% true. You only get that "default pickup amount" if you first got a weapon at the place the weapon is placed in a map. Try this: Drop 2 asmd guns one with 5 one with 12 bullets. If you have no ASMD and then first get the 5 bullet you have 5 ammo, then get the 12 bullet and you'll have 10 ammo, not 17 and not 25.

The general rule is:
When you get a gun you already have, it adds the same amount of ammo as the amount of ammo in the gun you picked up first.

(not necessary first after you respawned, but when you didnt have the gun)

BTW with a dead-body-gun i mean a gun which remains on the ground when someone died, and also a gun which is thrown away.

[Kobra]

confusing ...

[}TCP{Wolf]

Yea especially since that's not what the code says. There may be version differences or even differences between visible source and compiled. Just like the shieldbelt where the textbuffers are wrong too lol...

Anyway I'm still working this one out and in the end it will just give you the correct amount of ammo no matter what

[Taz]

we'll see

[}TCP{Ramses]

Have some faith Taz

[Xavious]

yes have faith in the wolf...sure he'll manage it...just so long as all his time isnt taken up by all our qustions...